-
Notifications
You must be signed in to change notification settings - Fork 747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Must call prepare or prepareAsync when instantiating a new MediaPlayer and not using create() #184
Conversation
…r and not using create()
2e175ad
to
f444215
Compare
How can I use this version of react-native-sound in my app? With the android issue fixed. |
Hi @SoorajChandran, you can use this branch by running:
|
It appears that if By removing
|
@fabiancook That is true, but using .prepare rather than .prepareAsync means network playback is problematic as the whole thread is blocked until enough data has been downloaded, which can be 10+ seconds on a slow connection. |
@benvium I think that is a different issue. They are still using |
@ndbroadbent Thanks all. If @fabiancook's suggestion looks good can we update this PR and I'll merge it in. Would be good to be absolutely sure that Android playback works in all the cases |
I have been using my changes in production, working great |
@fabiancook Thanks - do you have a PR I can merge with those changes in? |
One moment :) |
I'm closing this for now as I believe the issue is fixed in 0.10.2. Let me know if not and I'll re-open. |
I think we should reopen the issue. |
Android URL support was broken by #162 (no sounds were playing), so this is the fix for that.